Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OGM-1592: Add 5.4.2.Final migration guide #1136

Merged
merged 2 commits into from
Sep 12, 2024
Merged

Conversation

jyemin
Copy link
Contributor

@jyemin jyemin commented Sep 10, 2024

@jyemin jyemin changed the title OGM-1592: Add 5.4.2.Final migration guid OGM-1592: Add 5.4.2.Final migration guide Sep 10, 2024
Copy link
Member

@DavideD DavideD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you replace hibernate-ogm with Hibernate OGM everywhere, please?
I've also left a couple of comments, but overall looks fine to me.


Recent versions of the MongoDB server have removed support for some features on which hibernate-ogm depend. In particular:

* MongoDB 4.2 removed support for the `$eval` command, on which hibernate-ogm support for stored procedures depends.
Copy link
Member

@DavideD DavideD Sep 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It probably worth mentioning that native queries won't support maxscan and snapshot anymore: https://github.com/hibernate/hibernate-ogm/pull/1134/files#diff-8b6ff949d6524f98fc432f5eae5b7cec1c828e9ef1281930933b72ef0cc9cdb9L1241

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@jyemin
Copy link
Contributor Author

jyemin commented Sep 11, 2024

Could you replace hibernate-ogm with Hibernate OGM everywhere, please?

Done

@jyemin jyemin requested a review from DavideD September 11, 2024 15:07
@DavideD DavideD merged commit efc897a into hibernate:main Sep 12, 2024
6 checks passed
@DavideD
Copy link
Member

DavideD commented Sep 12, 2024

Merged, thanks.
I also added a link to the existing migration guide: 133f089

@yrodiere
Copy link
Member

Hey @DavideD , did you check that this migration guide will actually get rendered?

@DavideD
Copy link
Member

DavideD commented Sep 16, 2024

I didn't :/

Anyway, I will fix it in a bit

@yrodiere
Copy link
Member

Thanks!

Like I said before, feel free to have a look at how it's done in Hibernate Search, where we do include the migration guide within the project (and use Maven).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants