-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OGM-1592: Add 5.4.2.Final migration guide #1136
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you replace hibernate-ogm
with Hibernate OGM
everywhere, please?
I've also left a couple of comments, but overall looks fine to me.
|
||
Recent versions of the MongoDB server have removed support for some features on which hibernate-ogm depend. In particular: | ||
|
||
* MongoDB 4.2 removed support for the `$eval` command, on which hibernate-ogm support for stored procedures depends. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It probably worth mentioning that native queries won't support maxscan
and snapshot
anymore: https://github.com/hibernate/hibernate-ogm/pull/1134/files#diff-8b6ff949d6524f98fc432f5eae5b7cec1c828e9ef1281930933b72ef0cc9cdb9L1241
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Done |
Merged, thanks. |
Hey @DavideD , did you check that this migration guide will actually get rendered? |
I didn't :/ Anyway, I will fix it in a bit |
Thanks! Like I said before, feel free to have a look at how it's done in Hibernate Search, where we do include the migration guide within the project (and use Maven). |
https://hibernate.atlassian.net/browse/OGM-1592